fix(feishu): remove tool call status display to prevent streaming reset#313
Open
39499740 wants to merge 1 commit intodataelement:mainfrom
Open
fix(feishu): remove tool call status display to prevent streaming reset#31339499740 wants to merge 1 commit intodataelement:mainfrom
39499740 wants to merge 1 commit intodataelement:mainfrom
Conversation
The tool call status display (⏳/✅ indicators) was originally added to work around Feishu card block rendering limitations. Now that CardKit streaming mode is used, injecting tool status text into the streaming element causes the output to be rewritten from scratch, creating visible resets and flickers. Changes: - Remove _TOOL_STATUS_KEEP_LINES constant - Remove _tool_status_running/_tool_status_done state tracking - Remove _ws_on_tool_call callback function - Simplify _build_card() (remove tool_status_lines parameter) - Simplify _flush_stream() CardKit and Patch paths - Stop passing on_tool_call to _call_agent_llm() Closes: dataelement#312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove tool call status display (⏳/✅ indicators) from the Feishu channel to prevent CardKit streaming output from being reset/flickering.
The tool call status display was originally added to work around Feishu card block rendering limitations. Now that CardKit streaming mode is used, injecting tool status text into the streaming element causes the output to be rewritten from scratch, creating visible resets and flickers.
Fixes #312
Changes
_TOOL_STATUS_KEEP_LINESconstant_tool_status_running/_tool_status_donestate tracking variables_ws_on_tool_callcallback function_build_card()— removetool_status_linesparameter and rendering logic_flush_stream()— CardKit path directly uses accumulated text; Patch path hash calculation simplifiedon_tool_callto_call_agent_llm()for the Feishu text streaming pathImpact
_handle_feishu_file) is unaffectedChecklist