Add support for mutual authentication via TLS #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shearn89
force-pushed
the
feat/mutual-tls
branch
from
ce511ff
to
6d4c626
Compare
|
internal/services/repository/resource_repository_docker_hosted.go:48:12: cannot use repository.HostedStorage{…} (value of type "github.com/datadrivers/go-nexus-client/nexus3/schema/repository".HostedStorage) as "github.com/datadrivers/go-nexus-client/nexus3/schema/repository".DockerHostedStorage value in struct literal
internal/services/repository/resource_repository_docker_hosted.go:112:61: cannot use &repo.Storage (value of type *"github.com/datadrivers/go-nexus-client/nexus3/schema/repository".DockerHostedStorage) as *"github.com/datadrivers/go-nexus-client/nexus3/schema/repository".HostedStorage value in argument to flattenHostedStorage |
shearn89
force-pushed
the
feat/mutual-tls
branch
from
6d4c626
to
fb58a31
Compare
|
@shearn89 please rebase your PR |
Prior to this change, there was no way to pass in a client certificate if you had set up Nexus behind a load balancer with mutual auth configured. This change exposes some new configuration values that allow you to pass in a path to a file on disk containing your client key/cert (which can be in a single file) and optionally a Root CA.
shearn89
force-pushed
the
feat/mutual-tls
branch
from
fb58a31
to
ad6e938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, there was no way to pass in a client certificate if you had set up Nexus behind a load balancer with mutual auth configured.
This change exposes some new configuration values that allow you to pass in a path to a file on disk containing your client key/cert (which can be in a single file) and optionally a Root CA.
Follows on from datadrivers/go-nexus-client#146