Fixed code review issues, add vscode files on gitignore

.gitignore

@@ -44,4 +44,6 @@ crash.log
 
 credentials.json
 
-.terraform.lock.hcl
+.terraform*
+
+**/*.vscode

modules/secure-cloud-run-security/README.md

@@ -4,7 +4,8 @@ This module handles the basic deployment security configurations for Cloud Run u
 
 The resources/services/activations/deletions that this module will create/trigger are:
 
-* Creates KMS Keyring and Key for [customer managed encryption keys](https://cloud.google.com/run/docs/securing/using-cmek) in the **KMS Project**.
+* Creates KMS Keyring and Key for [customer managed encryption keys](https://cloud.google.com/run/docs/securing/using-cmek) in the **KMS Project**
+to be used by Cloud Run.
 * Enables Organization Policies related to Cloud Run in the **Serverless Project**.
   * Allow Ingress only from internal and Cloud Load Balancing.
   * Allow VPC Egress to Private Ranges Only.
@@ -83,10 +84,8 @@ module "cloud_run_security" {
 
 | Name | Description |
 |------|-------------|
-| key | Key self link. |
-| keyring | Self link of the keyring. |
-| keyring\_name | Name of the keyring. |
+| key\_self\_link | Key self link. |
 | keyring\_resource | Keyring resource. |
+| keyring\_self\_link | Self link of the keyring. |
 
 <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
-

modules/secure-cloud-run-security/outputs.tf

@@ -14,21 +14,16 @@
  * limitations under the License.
  */
 
-output "key" {
+output "key_self_link" {
   description = "Key self link."
   value       = module.cloud_run_kms.keys[var.key_name]
 }
 
-output "keyring" {
+output "keyring_self_link" {
   description = "Self link of the keyring."
   value       = module.cloud_run_kms.keyring
 }
 
-output "keyring_name" {
-  description = "Name of the keyring."
-  value       = module.cloud_run_kms.keyring_name
-}
-
 output "keyring_resource" {
   description = "Keyring resource."
   value       = module.cloud_run_kms.keyring_resource