Skip to content

Commit

Permalink
Fix typos (#337)
Browse files Browse the repository at this point in the history
* Fix typos

* Fix typo in AVRO test file

* Improve CHANGELOG message
  • Loading branch information
roykoand authored Jul 18, 2024
1 parent 90e4d8f commit bb9c8aa
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- Fix import of pyspark for type-checking when pyspark isn't required as a module (#312)- `datacontract import --format spark`: Import from Spark tables (#326)
- Fix an issue where specifying `glue_table` as parameter did not filter the tables and returned all tables instead from `source` instead (#333)
- Fix an issue where specifying `glue_table` as parameter did not filter the tables and instead returned all tables from `source` database (#333)

## [0.10.9] - 2024-07-03

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ run.result

Works with Spark DataFrames.
DataFrames need to be created as named temporary views.
Multiple temporary views are suppored if your data contract contains multiple models.
Multiple temporary views are supported if your data contract contains multiple models.

Testing DataFrames is useful to test your datasets in a pipeline before writing them to a data source.

Expand Down Expand Up @@ -1169,7 +1169,7 @@ Examples: adding models or fields
- Add the models or fields in the datacontract.yaml
- Increment the minor version of the datacontract.yaml on any change. Simply edit the datacontract.yaml for this.
- You need a policy that these changes are non-breaking. That means that one cannot use the star expression in SQL to query a table under contract. Make the consequences known.
- Fail the build in the Pull Request if a datacontract.yaml accidentially adds a breaking change even despite only a minor version change
- Fail the build in the Pull Request if a datacontract.yaml accidentally adds a breaking change even despite only a minor version change
```bash
$ datacontract breaking datacontract-from-pr.yaml datacontract-from-main.yaml
```
Expand Down
2 changes: 1 addition & 1 deletion datacontract/imports/importer_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def create(self, name) -> Importer:
importers = self.dict_importer.copy()
importers.update(self.dict_lazy_importer.copy())
if name not in importers.keys():
raise ValueError(f"The '{name}' format is not suportted.")
raise ValueError(f"The '{name}' format is not supported.")
importer_class = importers[name]
if type(importers[name]) is tuple:
importer_class = load_module_class(module_path=importers[name][0], class_name=importers[name][1])
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/avro/data/arrays.avsc
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"type": "int"
},
{
"name": "adresses",
"doc": "Adresses of a customer",
"name": "addresses",
"doc": "Addresses of a customer",
"type": {
"type": "array",
"items": {
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/avro/data/orders.avsc
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
"type": "double"
},
{
"name": "emailadresses",
"doc": "Different email adresses of a customer",
"name": "emailaddresses",
"doc": "Different email addresses of a customer",
"type": {
"type": "array",
"items": "string",
Expand Down
8 changes: 4 additions & 4 deletions tests/test_import_avro.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ def test_import_avro_schema():
orderunits:
type: double
required: true
emailadresses:
emailaddresses:
type: array
description: Different email adresses of a customer
description: Different email addresses of a customer
items:
type: string
format: email
Expand Down Expand Up @@ -98,10 +98,10 @@ def test_import_avro_arrays_of_records_and_nested_arrays():
orderid:
type: int
required: true
adresses:
addresses:
type: array
required: true
description: Adresses of a customer
description: Addresses of a customer
items:
type: object
fields:
Expand Down

0 comments on commit bb9c8aa

Please sign in to comment.