Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spanner Graph] Get node edges. #1446

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[Spanner Graph] Get node edges. #1446

merged 1 commit into from
Nov 6, 2024

Conversation

keyurva
Copy link
Contributor

@keyurva keyurva commented Nov 6, 2024

  • Fetching edges instead of nodes inline with the new schema changes.
  • Currently the edges are duplicated and that is reflected in the goldens.
    • We should regenerate the goldens once that is fixed.

@keyurva keyurva requested a review from n-h-diaz November 6, 2024 03:18
n-h-diaz
n-h-diaz approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@n-h-diaz n-h-diaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try to remove the duplicates

@keyurva keyurva merged commit c163577 into datacommonsorg:master Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-h-diaz n-h-diaz n-h-diaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyurva @n-h-diaz