-
Notifications
You must be signed in to change notification settings - Fork 125
Internet Access CRDC import autorefresh #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @shapateriya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a comprehensive data import pipeline to integrate 'Internet Access and Devices' data from the Civil Rights Data Collection (CRDC). It encompasses a Python script for automated data acquisition and preprocessing, alongside all essential configuration and schema definitions. The goal is to ingest this data as new statistical variables, offering insights into internet access within schools, specifically focusing on Wi-Fi enabled devices and the presence of juvenile justice facilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new data import for CRDC Internet Access data. The changes include the download script, configuration files, and generated MCF files. The overall structure is good, but there are a few issues to address. In download.py, the get_full_year function has a bug that will cause issues in the long term. The README.md has an incorrect title. There is also a duplicated script command in manifest.json and README.md which is a maintainability concern. I've provided suggestions to fix these issues.
| "scripts": [ | ||
| "python3 ../../../tools/statvar_importer/stat_var_processor.py --input_data=input_files/*.csv --pv_map=common_pvmap.csv --existing_statvar_mcf=gs://unresolved_mcf/scripts/statvar/stat_vars.mcf --config_file=common_metadata.csv --output_path=output/internet_access" | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script command is duplicated in statvar_imports/crdc/internet_access/README.md (line 23). This duplication can lead to maintenance issues, as any changes would need to be made in both places. To improve maintainability, consider making this manifest file the single source of truth and referencing it from the README, for example by stating "See manifest.json for the script command."
No description provided.