[DO NOT SUBMIT] Add dockerfile

[gmechali]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @gmechali, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a Dockerfile to containerize the application, making it easily deployable and manageable in containerized environments. The Dockerfile sets up a Python 3.11 slim environment, installs the necessary package, configures logging and port exposure, and includes a health check to ensure the application's readiness.

Highlights

• New Dockerfile: A new Dockerfile has been added to the repository, enabling the containerization of the application.
• Base Image: The Dockerfile uses python:3.11-slim as its base image, providing a lightweight Python environment.
• Application Installation: The datacommons-mcp package is installed using pip with --no-cache-dir to optimize image size.
• Environment Configuration: Environment variables PYTHONUNBUFFERED=1 and PORT=8080 are set for improved logging and port exposure.
• Health Check: A HEALTHCHECK instruction is included, using curl to verify the application's responsiveness on port 8080, which is beneficial for platforms like Cloud Run.
• Application Command: The CMD instruction is configured to run datacommons-mcp serve http binding to 0.0.0.0 and the exposed port 8080.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a Dockerfile to containerize the application. While this is a great addition, the current implementation has several areas for improvement regarding security, correctness, and Docker best practices. My review provides suggestions to build the image from local source code instead of PyPI, fix a critical issue with the HEALTHCHECK command, run the container as a non-root user for better security, and ensure the application port is configurable via environment variables as is standard for containerized applications.

[gemini-code-assist]

The python:3.11-slim base image does not include curl, which will cause the HEALTHCHECK to fail and may lead to the container being constantly restarted by an orchestrator like Cloud Run. You need to install curl first. Additionally, the port is hardcoded, and it's better to use the $PORT environment variable. I've also added some recommended flags to the HEALTHCHECK for better reliability.

# Install curl for healthcheck
RUN apt-get update && apt-get install -y curl --no-install-recommends && rm -rf /var/lib/apt/lists/*

# HEALTHCHECK: Basic check to ensure the server is responsive
# This helps Cloud Run know if the container is zombie
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
  CMD curl -f http://localhost:${PORT}/health || exit 1

[gemini-code-assist]

The Dockerfile currently installs datacommons-mcp from PyPI. This means any local changes made in this repository won't be included in the Docker image, making it difficult to test new code. To build an image with the current source code, you should copy the package source into the image and install it from there.

WORKDIR /app

# Copy the package source code
COPY ./packages/datacommons-mcp /app

# Install the package from the copied source
RUN pip install --no-cache-dir .

[gemini-code-assist]

There are two issues here:

1. Security: Running containers as the root user is a security risk. It's a best practice to create and switch to a non-root user.
2. Configuration: The port 8080 is hardcoded. This prevents overriding the port using the PORT environment variable, which is a standard practice for containerized applications. The exec form of CMD does not perform variable substitution, so you need to use sh -c to use the $PORT variable.

My suggestion addresses both points.

# Create and switch to a non-root user
RUN addgroup --system app && adduser --system --ingroup app app
USER app

# THE COMMAND
# 1. Bind to 0.0.0.0 (Crucial for Cloud Run)
# 2. Bind to the environment variable PORT
CMD ["sh", "-c", "datacommons-mcp serve http --host 0.0.0.0 --port $PORT"]