ADR-001 + drift-check cross-repo + composite action python-ci - #26
Merged
Conversation
This was referenced Aug 16, 2026
…n, rna-aiuti-stato, costituzione-italiana, data-advocacy, partecipate-monitor, project-template)
Gabrymi93
added a commit
that referenced
this pull request
Aug 16, 2026
… dataset-config-check) (#27) * docs(adr): ADR-001 accepted dopo merge #26 * feat: composite action gcs-auth (auth GCP JSON/base64 + output ready) * feat: reusable workflow registry-update-pr (build → diff → draft PR) * feat: reusable workflow dataset-config-check (loop preflight su dataset.yml) * feat(drift-check): controlli E/F/G su componenti pipeline + ADR step 5 in corso * fix(drift-check): data-advocacy fuori scope (privato) + skip robusto su 404 * fix: registry-update-pr da reusable a composite action (il registry deriva dai parquet locali, va nello stesso job del run) * refactor(registry-update-pr): usa il toolkit già nel job (no reinstall, versione coerente col run) * docs(adr): convenzione dipendenze (pyproject per pacchetti, requirements per dataset puri) * docs(adr): §8 regole di dichiarazione (transitive non ripetute, versione nel repo, extra per contesto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Pone le fondamenta per la standardizzazione dei workflow dell'org (ADR-001):
docs/adr/): modello a 4 layer (YAML orchestratore → Makefile thin → package org → componenti condivisi), regola d'oro "la logica non vive mai in YAML", confine semantico e processo di cambiamento.scripts/drift_check.py+ job intemplates.yml): verifica via API GitHub che i repo in scope usino i componenti condivisi. ERROR (bloccante) su copie inline dei reusable; WARN su setup-python inline, versioni action fuori allowlist, lint/test inline.python-ci(actions/python-ci): ruff + mypy + pytest con soglia coverage come step composabili (stesso pattern dipython-setup).python-setup,test-audit-reusable) etemplates.ymlportati aactions/*@v7(allowlist canonica).Contesto collegato
ADR-001 documentato in questa PR. Passi 1-4 dell'implementazione.
Cosa cambia
Impatto
Verifica
python scripts/drift_check.pyeseguito contro l'org reale: 1 ERROR atteso (lab-connectors, copia inlinetest-audit) che si chiude al merge della PR consumer corrispondente.Controlli
Note per chi revisiona
lab-connectors,toolkit,source-observatory,agent-context-builder,lab-dashboard), perché usanopython-ci@mainche nasce qui.drift-checksarà rosso finchélab-connectorsnon migra su main (è il segnale voluto, non blocca il merge).acceptedal merge; contatore repo nel rate-limit;dataset-incubator/lint.ymlflaggato (WARN) pur non essendo un CI Python standard; unit test perdrift_check.py(infra pytest da aggiungere al repo).