Schema 4.6 draft by ashwinisukale · Pull Request #144 · datacite/schema

ashwinisukale · 2024-10-14T10:26:05Z

Purpose

closes: #141

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

codycooperross

This is a great start, @ashwinisukale , but can you also add tests for the new relatedIdentifierType, contributorType, relationType, and dateType values? See the summary of changes here: https://docs.google.com/document/d/1RllY4Q-_Ls9gHSfy9Iuwlctv0uV4E_S6Sg56rvkMt1o/edit#heading=h.76dlmbn6ivq4

spec/kernel-4.5/other_spec.rb

svogt0511

How does this release play with the stylistic changes that Kelly is doing? Are they being released at the same time?

source/meta/kernel-4.6/index.html.md

source/_four.html.md.erb

source/meta/kernel-4/index.html.md

spec/kernel-4.5/other_spec.rb

codycooperross · 2024-10-16T14:40:49Z

How does this release play with the stylistic changes that Kelly is doing? Are they being released at the same time?

@KellyStathis I'm not sure I have the most context on this—can you provide some insight?

…amples

ashwinisukale · 2024-10-22T13:36:11Z

spec/kernel-4.6/example_with_full_spec.rb

@codycooperross @svogt0511

I have added most of the test cases in this file, instead of having multiple files for testing different part of the XML. I will create a issue which will clean all the tests inside schema. Right now they are all having incorrect file path.

Looks good. The only one I don't see is 'dateType: Coverage'. That may be elsewhere?

Thats was a good catch, adding it

I just added all the date types and tested its presence.

svogt0511 · 2024-10-23T21:15:20Z

spec/kernel-4.6/other_spec.rb

2nd ResourceTypeGeneral in other_spec.rb should have 'Project' instead of 'Award'?

KellyStathis · 2024-10-23T21:39:05Z

How does this release play with the stylistic changes that Kelly is doing? Are they being released at the same time?

@KellyStathis I'm not sure I have the most context on this—can you provide some insight?

Sorry @codycooperross and @svogt0511 I missed this last week.

The redesign of the schema site is on track to launch at the end of October. Once that's complete, I would merge those changes into this schema-4.6-draft branch. It is mostly CSS changes, but some of the pages will have minor structural changes (e.g., changing a heading level) that we'll want to incorporate here. There may be a few merge conflicts.

codycooperross

I think one of the last pieces of this work, assuming that all the new values are tested as valid against the XSD, is to copy all of the spec/kernel-4.6 tests to the spec/kernel-4 folder. These two should be identical, to my memory, because the XSD is identical as well. @svogt0511 does that sound right?

ashwinisukale · 2024-10-25T07:39:52Z

I think one of the last pieces of this work, assuming that all the new values are tested as valid against the XSD, is to copy all of the spec/kernel-4.6 tests to the spec/kernel-4 folder. These two should be identical, to my memory, because the XSD is identical as well. @svogt0511 does that sound right?

I have created a ticket which will address this #146 here I am also addressing correction of test cases in other versions.

svogt0511

As far as I can see my comments have been addressed. I am going to approve this pending resolution of Cody's comments. I assume that this is not going to be released until @KellyStathis is ready to make the announcement of 4.6, and at that time, everything related to 4.6 will be released. I am also assuming that 4.6 is scheduled to go after the October release of the site format/css changes.

# Conflicts: # source/_versions.html.md.erb # source/meta/kernel-4/index.html.md

yarikoptic · 2024-11-01T19:27:57Z

source/meta/kernel-4.6/example/datacite-example-multilingual-v4.xml

+        <date dateType="Available">2024-01-01</date>
+    </dates>      
+    <descriptions>
+        <description xml:lang="en" descriptionType="Abstract">This chapter reviews selected landmarks ocurred in Chemistry basic research in the last 5 years</description>


Suggested change

<description xml:lang="en" descriptionType="Abstract">This chapter reviews selected landmarks ocurred in Chemistry basic research in the last 5 years</description>

<description xml:lang="en" descriptionType="Abstract">This chapter reviews selected landmarks occurred in Chemistry basic research in the last 5 years</description>

ref:

Add codespell support (config, workflow to detect/not fix) and make it fix few typos #148

…o this page

KellyStathis and others added 2 commits August 29, 2024 16:39

add draft of 4.6

2ade779

Fixed test cases and added debugger gem and fixed ruby version

8b0d11d

codycooperross requested changes Oct 16, 2024

View reviewed changes

spec/kernel-4.5/other_spec.rb Outdated Show resolved Hide resolved

spec/kernel-4.5/other_spec.rb Outdated Show resolved Hide resolved

svogt0511 reviewed Oct 16, 2024

View reviewed changes

source/meta/kernel-4.6/index.html.md Show resolved Hide resolved

source/_four.html.md.erb Show resolved Hide resolved

source/meta/kernel-4/index.html.md Show resolved Hide resolved

spec/kernel-4.5/other_spec.rb Outdated Show resolved Hide resolved

KellyStathis added 4 commits October 16, 2024 15:00

schema 4.6: update "full" XML example and add placeholders for new ex…

26bbf85

…amples

schema 4.6: add placeholder example XML files and links

80bd039

add Project example

a3ce031

add Coverage example

8a3d891

ashwinisukale self-assigned this Oct 18, 2024

Schema 4.6 test cases updated and corrected

6421577

ashwinisukale commented Oct 22, 2024

View reviewed changes

svogt0511 reviewed Oct 23, 2024

View reviewed changes

spec/kernel-4.6/other_spec.rb

Copy link

Contributor

svogt0511 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd ResourceTypeGeneral in other_spec.rb should have 'Project' instead of 'Award'?

added all missing date types for testing

36998f9

ashwinisukale requested review from KellyStathis, codycooperross and svogt0511 October 24, 2024 06:50

fixed tests

21545ac

codycooperross reviewed Oct 24, 2024

View reviewed changes

ashwinisukale requested a review from codycooperross October 25, 2024 07:40

svogt0511 approved these changes Oct 25, 2024

View reviewed changes

KellyStathis added 3 commits October 31, 2024 13:47

Merge branch 'master' into schema-4.6-draft

f20f3f0

# Conflicts: # source/_versions.html.md.erb # source/meta/kernel-4/index.html.md

fix links for 4.6 dois

fd29562

add missing hr

a614970

yarikoptic mentioned this pull request Nov 1, 2024

Add codespell support (config, workflow to detect/not fix) and make it fix few typos #148

Closed

yarikoptic reviewed Nov 1, 2024

View reviewed changes

KellyStathis added 2 commits November 8, 2024 12:48

updates to 4.6 examples (work in progress)

0ead2b2

update translation examples

460e2ba

KellyStathis added 7 commits November 8, 2024 15:08

add links to blog post examples

054b080

Merge branch 'master' into schema-4.6-draft

271d4d3

add parallel languages example

f9c354a

add parallel languages example

8d3a424

add 4.6 update notes

a4b769e

update release date

1cf1e8d

change "older versions" to "release history" and add latest version t…

4348eea

…o this page

KellyStathis approved these changes Nov 22, 2024

View reviewed changes

codycooperross approved these changes Dec 4, 2024

View reviewed changes

fix typo

e66ad6a

codycooperross self-requested a review December 5, 2024 13:30

codycooperross approved these changes Dec 5, 2024

View reviewed changes

codycooperross merged commit f5388e7 into master Dec 5, 2024

codycooperross deleted the schema-4.6-draft branch December 5, 2024 13:30

	<description xml:lang="en" descriptionType="Abstract">This chapter reviews selected landmarks ocurred in Chemistry basic research in the last 5 years</description>
	<description xml:lang="en" descriptionType="Abstract">This chapter reviews selected landmarks occurred in Chemistry basic research in the last 5 years</description>

Conversation

ashwinisukale commented Oct 14, 2024

Purpose

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

Reviewer, please remember our guidelines:

Uh oh!

codycooperross left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

svogt0511 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codycooperross commented Oct 16, 2024

Uh oh!

ashwinisukale Oct 22, 2024

Choose a reason for hiding this comment

Uh oh!

svogt0511 Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

ashwinisukale Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

ashwinisukale Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

svogt0511 Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

KellyStathis commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codycooperross left a comment

Choose a reason for hiding this comment

Uh oh!

ashwinisukale commented Oct 25, 2024

Uh oh!

svogt0511 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yarikoptic Nov 1, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KellyStathis commented Oct 23, 2024 •

edited

Loading

svogt0511 left a comment •

edited

Loading