Skip to content

fix(core): added new parsing logic for the configurations files #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix(core): added new parsing logic for the configurations files #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b64b49
fix(dependency): added pytz as a direct dependency
Anu-Ra-g Jan 29, 2024
ac2ec3d
fix(core): added new parsing logic for the configuration files
Anu-Ra-g Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions datachecks/core/configuration/configuration_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,12 @@ def load_configuration(configuration_path: str) -> Configuration:
"storage": None,
}
for config_dict in config_dict_list:
final_config_dict["data_sources"].extend(config_dict["data_sources"])
final_config_dict["metrics"].extend(config_dict["metrics"])
if "data_sources" in config_dict:
final_config_dict["data_sources"].extend(
config_dict["data_sources"]
)
if "metrics" in config_dict:
final_config_dict["metrics"].extend(config_dict["metrics"])
if "storage" in config_dict:
final_config_dict["storage"] = config_dict["storage"]

Expand Down
2 changes: 1 addition & 1 deletion datachecks/report/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class DashboardInfo:
dashboard: DashboardMetricOverview


class GroupedMetricsType(List[str], Enum):
class GroupedMetricsType(Enum):
reliability = ["row_count", "document_count", "freshness"]
numeric = ["min", "max", "avg", "sum", "stddev", "variance"]
uniqueness = ["distinct_count", "duplicate_count"]
Expand Down
Loading