Skip to content

feat: ICoordinator#19

Merged
YukiTsuchida merged 4 commits intofeature/coordinatorfrom
def-interface-coordinator
Nov 6, 2025
Merged

feat: ICoordinator#19
YukiTsuchida merged 4 commits intofeature/coordinatorfrom
def-interface-coordinator

Conversation

@YukiTsuchida
Copy link
Contributor

@YukiTsuchida YukiTsuchida commented Nov 5, 2025

  • Defined the ICoordinator interface required by the Cross Coordinator.
  • Added the Protocol Buffers files needed for the ICoordinator definition.

@YukiTsuchida YukiTsuchida changed the base branch from main to def-interface-authenticator November 5, 2025 03:02
@@ -3,6 +3,8 @@ syntax = "proto3";
import "gogoproto/gogo.proto";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with reference to the proto of the cross repository

@@ -0,0 +1,11 @@
syntax = "proto3";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with reference to the proto of the cross repository

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

LCOV of commit e4eac14 during Coverage Report #34

Summary coverage rate:
  lines......: 100.0% (77 of 77 lines)
  functions..: 100.0% (22 of 22 functions)
  branches...: no data found

Files changed coverage rate: n/a

Full coverage report

message CoordinatorState {
option (gogoproto.equal) = false;

Tx.CommitProtocol commit_protocol = 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original proto, the field was named type, but since type is a reserved word in Solidity, replaced it with commit_protocol.

@YukiTsuchida YukiTsuchida self-assigned this Nov 5, 2025
@YukiTsuchida YukiTsuchida changed the base branch from def-interface-authenticator to feature/coordinator November 6, 2025 01:14
Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@YukiTsuchida YukiTsuchida merged commit 5ac4183 into feature/coordinator Nov 6, 2025
5 checks passed
@YukiTsuchida YukiTsuchida mentioned this pull request Dec 12, 2025
@YukiTsuchida YukiTsuchida deleted the def-interface-coordinator branch January 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants