Skip to content

feat: IInitiator#17

Merged
YukiTsuchida merged 4 commits intofeature/coordinatorfrom
def-interface-initiator
Nov 6, 2025
Merged

feat: IInitiator#17
YukiTsuchida merged 4 commits intofeature/coordinatorfrom
def-interface-initiator

Conversation

@YukiTsuchida
Copy link
Contributor

@YukiTsuchida YukiTsuchida commented Nov 5, 2025 •
edited
Loading

  • Defined the IInitiator interface required by the Cross Coordinator.
  • Added the Protocol Buffers files needed for the IInitiator definition.
  • Fixed a bug in the pre-commit hook.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025 •
edited
Loading

LCOV of commit cc98902 during Coverage Report #29

Summary coverage rate:
  lines......: 100.0% (77 of 77 lines)
  functions..: 100.0% (22 of 22 functions)
  branches...: no data found

Files changed coverage rate: n/a

Full coverage report

YukiTsuchida
YukiTsuchida commented Nov 5, 2025
View reviewed changes
.husky/pre-commit
npm run fmt:sol

git add -A
npx lint-staged
Copy link
Contributor Author

@YukiTsuchida YukiTsuchida Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug where files without stage were committed, so fixed it by using lint-staged.

YukiTsuchida
YukiTsuchida commented Nov 5, 2025
View reviewed changes
proto/cross/core/initiator/Initiator.proto
@@ -0,0 +1,77 @@
syntax = "proto3";
Copy link
Contributor Author

@YukiTsuchida YukiTsuchida Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with reference to the proto of the cross repository

YukiTsuchida
YukiTsuchida commented Nov 5, 2025
View reviewed changes
proto/cross/core/tx/Tx.proto
@@ -0,0 +1,58 @@
syntax = "proto3";
Copy link
Contributor Author

@YukiTsuchida YukiTsuchida Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with reference to the proto of the cross repository

@YukiTsuchida YukiTsuchida changed the title feat: definition IInitiator feat: IInitiator Nov 5, 2025
@YukiTsuchida YukiTsuchida self-assigned this Nov 5, 2025
mattsu6666
mattsu6666 reviewed Nov 6, 2025
View reviewed changes
Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment👍

YukiTsuchida
YukiTsuchida commented Nov 6, 2025
View reviewed changes
package.json
"clean": "rm -rf build",
"test": "forge test -vvv",
"lint:sol": "solhint -f table 'src/**/*.sol' 'test/**/*.sol' 'script/**/*.sol'",
"lint:sol": "solhint -f table --max-warnings 0 'src/**/*.sol' 'test/**/*.sol' 'script/**/*.sol'",
Copy link
Contributor Author

@YukiTsuchida YukiTsuchida Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Treat solhint warnings as errors.

mattsu6666
mattsu6666 approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✅

@YukiTsuchida YukiTsuchida merged commit 3c2fb43 into feature/coordinator Nov 6, 2025
5 checks passed
@YukiTsuchida YukiTsuchida mentioned this pull request Dec 12, 2025
Merged
@YukiTsuchida YukiTsuchida deleted the def-interface-initiator branch January 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsu6666 mattsu6666 mattsu6666 approved these changes

Assignees

@YukiTsuchida YukiTsuchida

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YukiTsuchida @mattsu6666