Skip to content

Make the etherpad template more generic #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

p-j-smith
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

  • make the etherpad tempalte more generic
  • this is so the content of the template does not depend on the course material, otherwise we would need to update the template on every PR
  • use bulleted lists rather than numbered lists so the template can be copied to etherpad and keep the formatting looking okay

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

Copy link

github-actions bot commented Feb 1, 2024

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

Results of any additional workflows will appear here when they are done.

@p-j-smith p-j-smith requested a review from vhmcck February 1, 2024 09:02
github-actions bot pushed a commit that referenced this pull request Feb 1, 2024
Copy link
Contributor

@vhmcck vhmcck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little detail in the subtitle. Otherwise, it looks fine on my end.

@@ -3,215 +3,64 @@ title: Etherpad template
subtitle: Template text to paste in to collaborative document
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template text to paste into a collaborative document, such as Etherpad.

@p-j-smith p-j-smith requested a review from vhmcck March 14, 2024 08:41
@p-j-smith p-j-smith merged commit 9af622c into main Mar 14, 2024
@p-j-smith p-j-smith deleted the fix/etherpad-tempalte branch March 14, 2024 08:44
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
Auto-generated via {sandpaper}
Source  : 9af622c
Branch  : main
Author  : Paul Smith <paul.j.smith@ucl.ac.uk>
Time    : 2024-03-14 08:44:43 +0000
Message : Make the etherpad template more generic (#353)

* Make the etherpad template more generic

* clarify purpose of etherpad template
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
Auto-generated via {sandpaper}
Source  : 0a49ade
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-03-14 08:47:54 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 9af622c
Branch  : main
Author  : Paul Smith <paul.j.smith@ucl.ac.uk>
Time    : 2024-03-14 08:44:43 +0000
Message : Make the etherpad template more generic (#353)

* Make the etherpad template more generic

* clarify purpose of etherpad template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants