Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an instruction for rm - Fixes issue #240 #291

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

nairps
Copy link
Contributor

@nairps nairps commented Sep 22, 2020

Fixes #240

@akshayparopkari akshayparopkari added the type:clarification Suggest change for make lesson clearer label Sep 22, 2020
@akshayparopkari
Copy link
Contributor

Looks good to me 👍

@akshayparopkari
Copy link
Contributor

I will wait for a couple of days in case @datacarpentry/shell-genomics-maintainers have any inputs, before merging this PR.

@aschuerch
Copy link
Contributor

Useful addition, thank you @nairps . I corrected (I guess) a typo. Please have a look @nairps in "Files changed" or "Commits"

@akshayparopkari
Copy link
Contributor

@datacarpentry/shell-genomics-maintainers, is this PR ready to be merged?

@esallychang esallychang merged commit 2aca74e into datacarpentry:gh-pages Dec 22, 2020
@esallychang
Copy link
Contributor

Since both other @datacarpentry/shell-genomics-maintainers tagged here seem to like this PR and it looked good to me, went ahead and merged.

zkamvar pushed a commit that referenced this pull request May 8, 2023
Added an instruction for rm - Fixes issue #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:clarification Suggest change for make lesson clearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an instruction during rm
4 participants