Skip to content

Conversation

@yuanchaoma-db
Copy link
Contributor

@yuanchaoma-db yuanchaoma-db commented Jun 9, 2025

This is for publishing it to marketplace, similar to the ka-chat-bot project.

@yuanchaoma-db yuanchaoma-db requested a review from a team as a code owner June 9, 2025 21:19
@yuanchaoma-db yuanchaoma-db requested a review from esiol-db June 9, 2025 21:19
@alexott alexott requested a review from Copilot June 10, 2025 12:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new “conversational-agent-app” Databricks App for natural-language data queries via the Genie Conversation APIs.

  • Introduces dependency pins and SDK requirement
  • Implements the Genie client (genie_room.py) and entrypoints for query flows
  • Supplies manifest, deployment config, docs, and ownership metadata

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
requirements.txt Defines Python dependencies for the Dash UI and Databricks SDK
manifest.yaml Declares app metadata, resource specs, and API scopes
genie_room.py Implements GenieClient and conversation helpers
app.yaml Configures the container command and environment variable mapping
README.md Provides usage instructions, features, and deployment steps
CODEOWNERS Assigns ownership for the new app directory
Comments suppressed due to low confidence (2)

conversational-agent-app/genie_room.py:190

  • Consider adding unit tests for process_genie_response to cover both text and query attachment paths, ensuring DataFrame construction and fallback logic behave as expected.
def process_genie_response(client, conversation_id, message_id, complete_message) -> Tuple[Union[str, pd.DataFrame], Optional[str]]:

conversational-agent-app/app.yaml:7

  • The valueFrom key must be indented under the same list item as - name. It should be:
env:
  - name: "SERVING_ENDPOINT_NAME"
    valueFrom: "serving_endpoint"
  valueFrom: "serving_endpoint"

@yuanchaoma-db yuanchaoma-db requested a review from alexott June 10, 2025 21:51
@yuanchaoma-db
Copy link
Contributor Author

Thanks @alexott ! Comments addressed PTAL!

@alexott alexott merged commit 4a79498 into databrickslabs:main Jun 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants