Update ValidatorTestSuite #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeekSheikh
reviewed
Jul 27, 2021
Contributor
GeekSheikh
left a comment
GeekSheikh
left a comment
There was a problem hiding this comment.
Tests compiled and passed after one minor addition to imports. pushed it via commit just now. I haven't run through all the logic of all the tests, assuming you have. please re-submit for review when you're done adding tests.
…slabs/dataframe-rules-engine into update_validator_tests
GeekSheikh
approved these changes
Aug 6, 2021
Contributor
GeekSheikh
left a comment
GeekSheikh
left a comment
There was a problem hiding this comment.
excellent! Thank you for all of these fantastic enahcenemnts! :)
GeekSheikh
added a commit
that referenced
this pull request
Aug 15, 2021
* enable streaming * scaffolding for simpleExpr validation * completed refactor -- tests outstanding * refactor and enablement complete * updated readme * added implicit boolean * added filter for summary report * Update ValidatorTestSuite (#19) * Update Validator tests with API changes. * Add tests for implicit and explicit expression rules. * imported outstanding spark sql functions * Add test suite for Rules class. * Add tests for RuleSet class. * Add test for complex expressions on aggregates. * Fix isGrouped bug when groupBys array is empty by default or explicitly set. * Fix overloaded add function that merges 2 RuleSets. * Add ignoreCase and invertMatch to ValidateStrings and ValidateNumerics rule types. * Update documentation with latest features in categorical Rules. Co-authored-by: Daniel Tomes [GeekSheikh] <10840635+geeksheikh@users.noreply.github.com> * Update sbt (#23) * simple update to build sbt * Add scoverage. Co-authored-by: Will Girten <will.girten@databricks.com> * removed unused imports * Accept expanded sequence of Rules to RuleSet Class. * cleaning up (#30) * cleaning up * removed dependencies from assembly * Fix whitespaces and special characters in Rule Names (#25) * Parse white spaces and special characters in failure report. * Update variable name with more meaningful name. * Add method to remove whitespace and special characters from Rule names. * Simplify ruleName public accessor. * Change special character replacement to underscores. * Update warning messages and assign private ruleName only once. * Update demo notebook (#33) * Update demo notebook with examples of latest features added. * added scala demo example Co-authored-by: Daniel Tomes [GeekSheikh] <10840635+geeksheikh@users.noreply.github.com> * implemented new inclusive boundaries option (#32) * implemented new inclusive boundaries option * enhanced logic for upper and lower inclusivity * readme updated * Update validation logic for Bounds class. Add test case for inclusive boundary rules. (#35) Co-authored-by: Will Girten <47335283+goodwillpunning@users.noreply.github.com> Co-authored-by: Will Girten <47335283+goodwillpunning@users.noreply.github.com> Co-authored-by: Will Girten <will.girten@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
ValidatorTestSuiteso that all existing test cases work with API changes made in the branchenable_streaming, as well as adds tests for theRuleandRuleSetclasses.