[PLAT-104290] auto detect/remove overlapping blocks to be compacted to avoid compactor panics #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyi
changed the title
jnyi
force-pushed
the
PLAT-104290
branch
2 times, most recently
from
9298d89
to
283cdac
Compare
Signed-off-by: Yi Jin <yi.jin@databricks.com>
jnyi
force-pushed
the
PLAT-104290
branch
2 times, most recently
from
e5c7ca0
to
22159f6
Compare
jnyi
commented
Mar 22, 2024
| @@ -591,8 +591,6 @@ func (f *BaseFetcher) fetch(ctx context.Context, metrics *FetcherMetrics, filter | |||
| if tenant, ok := m.Thanos.Labels[metadata.TenantLabel]; ok { | |||
| numBlocksByTenant[tenant]++ | |||
| } else { | |||
| level.Error(f.logger).Log("msg", "found blocks without label "+metadata.TenantLabel, | |||
There was a problem hiding this comment.
this is verbose and not useful in testing
Signed-off-by: Yi Jin <yi.jin@databricks.com>
Signed-off-by: Yi Jin <yi.jin@databricks.com>
jnyi
force-pushed
the
PLAT-104290
branch
3 times, most recently
from
1141c66
to
7445895
Compare
jnyi
commented
Mar 22, 2024
| @@ -284,10 +283,6 @@ func NewDefaultGrouper( | |||
| Name: "thanos_compact_group_vertical_compactions_total", | |||
| Help: "Total number of group compaction attempts that resulted in a new block based on overlapping blocks.", | |||
| }, []string{"resolution"}), | |||
| overlappingBlocks: promauto.With(reg).NewCounterVec(prometheus.CounterOpts{ | |||
There was a problem hiding this comment.
move this metric to its own source file, this will avoid conflicts when merge from upstream.
jnyi
changed the title
hczhu-db
approved these changes
Mar 22, 2024
cmd/thanos/compact.go
Outdated
| @@ -786,6 +789,9 @@ func (cc *compactConfig) registerFlag(cmd extkingpin.FlagClause) { | |||
| "NOTE: This flag is ignored and (enabled) when --deduplication.replica-label flag is set."). | |||
| Hidden().Default("false").BoolVar(&cc.enableVerticalCompaction) | |||
|
|
|||
| cmd.Flag("compact.remove-overlapping", "In house flag to remove overlapping blocks. Turn this on to fix PLAT-104290."). | |||
There was a problem hiding this comment.
No point in putting a Jira ticket number in a public repo here. Just briefly describe the issue.
There was a problem hiding this comment.
aha, forgot this is public, let me fix it.
jnyi
force-pushed
the
PLAT-104290
branch
3 times, most recently
from
c606168
to
e6dbcf2
Compare
Signed-off-by: Yi Jin <yi.jin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a flag
enableOverlappingRemovalto control this.This will replace the
DefaultCompactionLifecycleCallbackas a new callback.This handles overlapping blocks before actually doing the compaction which could potentially causing halting or panic like thanos-io#6775
Changes
Verification
Deployed to dev, no panics, and overlapped blocks got deleted: