Use Jobs API 2.1 with name filter for databricks_job data source
#1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch switches to 2.1 version of Jobs API for List operation so we can more efficiently handle workspace with huge number of jobs (> 3000). It also uses new `name` parameter to search jobs by name in the `databricks_job` data source.
nfx
reviewed
Nov 9, 2022
| } | ||
| offset += len(resp.Jobs) | ||
| } | ||
| return jobs, nil |
There was a problem hiding this comment.
go sdk will generate the following logic. please reuse
var results []Job
ctx = useragent.InContext(ctx, "sdk-feature", "pagination")
for {
response, err := a.List(ctx, request)
if err != nil {
return nil, err
}
if len(response.Jobs) == 0 {
break
}
for _, v := range response.Jobs {
results = append(results, v)
}
request.Offset += int(len(response.Jobs))
}
return results, nilThere was a problem hiding this comment.
we'll need to look for SDK modification as it's doing the extra API call at the end.
| }) | ||
| } | ||
|
|
||
| func TestJobsAPIListMultiplePages(t *testing.T) { |
There was a problem hiding this comment.
what about duplicates that appear when job is added in the middle of iteration? :) you can skip this one here, though
nfx
approved these changes
Nov 10, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1744 +/- ##
=======================================
Coverage 89.98% 89.98%
=======================================
Files 141 141
Lines 11148 11171 +23
=======================================
+ Hits 10031 10052 +21
- Misses 712 713 +1
- Partials 405 406 +1
|
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…atabricks#1744) This patch switches to 2.1 version of Jobs API for List operation so we can more efficiently handle workspace with huge number of jobs (> 3000). It also uses new `name` parameter to search jobs by name in the `databricks_job` data source.
|
bn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch switches to 2.1 version of Jobs API for List operation so we can more efficiently handle workspaces with huge number of jobs (> 3000). It also uses new
nameparameter to search jobs by name in thedatabricks_jobdata source.