Skip to content

Conversation

ganeshchand
Copy link
Contributor

@ganeshchand ganeshchand commented Oct 17, 2016

Added sample code for reading a Redshift table with SparkR.

@codecov-io
Copy link

codecov-io commented Oct 17, 2016

Current coverage is 76.75% (diff: 100%)

Merging #282 into master will decrease coverage by 12.69%

@@             master       #282   diff @@
==========================================
  Files            12         12          
  Lines           654        654          
  Methods         526        526          
  Messages          0          0          
  Branches        128        128          
==========================================
- Hits            585        502    -83   
- Misses           69        152    +83   
  Partials          0          0          

Powered by Codecov. Last update 1873ab7...098b03f

@JoshRosen JoshRosen changed the title Updated README.md with a sample code to read a Redshift table in SparkR Updated README.md with sample code to read a Redshift table in SparkR Oct 18, 2016
@JoshRosen
Copy link
Contributor

This looks pretty good, but the style was slightly inconsistent with the existing examples so I went ahead and updated them. I'd also like to remove the separate Spark 1.6 and 2.x examples from the README since the current master README only applies to Spark 2.x (since Spark-redshift 2.x only supports Spark 2.x). Therefore I'd like to commit slightly different PRs against master and branch-1.x.

I'm going to make a quick update / edit to this now, then will commit this for master and will port a modified version to branch-1.x.

@JoshRosen JoshRosen closed this in da8b21f Oct 18, 2016
JoshRosen pushed a commit that referenced this pull request Oct 18, 2016
Added sample code for reading a Redshift table with SparkR.

Author: Ganesh Chand <ganeshchand@gmail.com>
Author: Josh Rosen <joshrosen@databricks.com>

Closes #282 from ganeshchand/patch-1.
@JoshRosen JoshRosen added this to the 1.1.1 milestone Oct 18, 2016
@JoshRosen JoshRosen self-assigned this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants