Custom JDBC column types back-port #247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Marc-André Tremblay <marcandre.tr@gmail.com> This patch had conflicts when merged, resolved by Committer: Josh Rosen <joshrosen@databricks.com> Closes databricks#220 from marctrem/custom-jdbc-column-types.
|
Hope you don't mind the back-port request for this. Won't be able to update to Spark 2.x for a while. I understand the desire to freeze on new features but this is something that would be extremely useful so I thought I'd open this pull request. |
Current coverage is 89.45% (diff: 83.33%)
@@ branch-1.x #247 diff @@
============================================
Files 13 13
Lines 681 683 +2
Methods 596 592 -4
Messages 0 0
Branches 85 91 +6
============================================
+ Hits 609 611 +2
Misses 72 72
Partials 0 0
|
|
Let me go ahead and run the integration tests with this. If they pass then I'll merge this into the next 1.x release. |
|
LGTM, so I'll merge this now. |
JoshRosen
pushed a commit
that referenced
this pull request
Aug 4, 2016
Back-port JDBC column types to 1.x branch. Author: Marc-Andre Tremblay <marcandre.tr@gmail.com> Closes #247 from nrstott/feature/custom-jdbc-column-types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port JDBC column types to 1.x branch.