Testing on travis-ci #20
Merged
+52
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBago
commented
Jun 14, 2017
.travis.yml
Outdated
| @@ -0,0 +1,29 @@ | |||
| sudo: required | |||
There was a problem hiding this comment.
This file is copied from graphframes.
MrBago
commented
Jun 14, 2017
| @@ -70,7 +70,7 @@ def compareArrays(self, values1, values2): | |||
| """ | |||
| values1 & values2 are {key => numpy array}. | |||
| """ | |||
| for k, v1 in values1.iteritems(): | |||
| for k, v1 in values1.items(): | |||
There was a problem hiding this comment.
For python3 compatibility.
MrBago
commented
Jun 14, 2017
| @@ -18,7 +18,7 @@ | |||
| from sparkdl.transformers.utils import InceptionV3Constants | |||
| from ..tests import SparkDLTestCase | |||
| from .image_utils import ImageNetOutputComparisonTestCase | |||
| import image_utils | |||
| from . import image_utils | |||
MrBago
commented
Jun 14, 2017
| @@ -34,12 +32,11 @@ | |||
|
|
|||
| class NamedImageTransformerImagenetTest(SparkDLTestCase): | |||
|
|
|||
| def test_inceptionV3_prediction(self): | |||
There was a problem hiding this comment.
Breaking this test up allows unused variables to go out of scope and be GCed.
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
===========================================
+ Coverage 50.88% 85.95% +35.06%
===========================================
Files 4 20 +16
Lines 169 1175 +1006
Branches 6 6
===========================================
+ Hits 86 1010 +924
- Misses 83 165 +82
Continue to review full report at Codecov.
|
|
@sueann Travis up and running! |
phi-dbq
reviewed
Jun 14, 2017
.travis.yml
Outdated
| @@ -0,0 +1,29 @@ | |||
| sudo: required | |||
|
|
|||
There was a problem hiding this comment.
We might need to add
jdk:
- oraclejdk8 # openJDK crashes sometimes; tensorframes is compiled w.r.t JDK8
following TensorFrames Travis settings https://github.com/databricks/tensorframes/blob/master/.travis.yml
|
LGTM! |
MrBago
force-pushed
the
travis-testing-and-py3
branch
from
bfc5dec to
42cabee
Compare
Python coverage.
MrBago
force-pushed
the
travis-testing-and-py3
branch
from
42cabee to
786ee77
Compare
3 tasks
sueann
approved these changes
Jun 20, 2017
| cls.imageArray = imageArray | ||
| cls.kerasPredict = kerasPredict | ||
|
|
||
| def test_buildtfgraphforname(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a travis config file and does a little refactoring to stay within travis's memory limit and pass tests using python3.