Use getResourceAsStream instead of getResource in tests #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasatdatabricks
approved these changes
Feb 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 34 34
Lines 1975 1975
Branches 45 45
=======================================
Hits 1636 1636
Misses 339 339Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls to
getResource(which look for resource files only on the local disk) with calls togetResourceAsStream, which uses the classloader to search for resource files anywhere in the classpath.