Upgraded to spark 2.0 #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a lot of functionality is hidden behind private access modifiers making it difficult to extend the functionality of the parsers without copying large chunks of code. These small changes make re-use much easier.
Was able to reinstate some of the access modifiers and instead extracted out extensible code from those methods into new overridable methods. Added some hierarchy to the parsers/readers so they can be switched out.
Feature/extensible parsers
|
@davidcrossland this package is not supposed to work with Spark 2.0. spark-csv has been inlined in Apache Spark 2.0 |
|
This related to a fork of spark-csv which was used by https://github.com/quartethealth/spark-fixedwidth, i needed to make use of this project for a customer. Unluckily it didnt work with spark 2.0, so i was forced to upgrade it. This was only intended to be a pull request for that specific repo, certainly not for the main codebase. Hopefully once Spark 2.0 is released i will be able to update that project, you could take a look at integrating fixed width files in spark-csv and save me a job ;) |
|
I see. Spark 2.0 was released a few months ago. Feel free to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.