Fix TypedConstraint equality check #1084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1081
Description
It looks like the root cause behind #1081 is because of how we determine equality between TypedConstraint objects. During incremental runs, we rely on the equality check to determine which constraints to drop or apply
dbt-databricks/dbt/adapters/databricks/relation_configs/constraints.py
Lines 30 to 32 in 6981678
The current default equality check is considering fields like
warn_unenforced
. This does not work because this is a user supplied config that has no meaning when we are creating aTypedConstraint
from existing Databricks relations. The Fix is to override the__eq__
to match the__hash__
which already ignores such fieldsChecklist
CHANGELOG.md
and added information about my change to the "dbt-databricks next" section.