-
Notifications
You must be signed in to change notification settings - Fork 145
SQLAlchemy 2: reorganise dialect files into a single directory #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
95ce138
Here's the layout recommended by SQLAlchemy's documentation:
fd0edce
(1/x) Move dialect files one directory up so that dialect layout will
c6fea52
WIP: update default paramstyle to be compatible with DBR (ROLL ME BAC…
08f551a
Set DBAPI paramstyle to match what DBR supports
158abc6
Update sqlalchemy e2e tests to get valid signal after parameterized q…
2232b15
After PECO-1109, remove skip markers for tests that depend on DECIMAL…
73585fb
Move tests files all into the dialect directory
a2dd5a7
No need to instruct pytest discovery to skip these tests now that they
ba4bb87
Update the conf file and the instructions for running tests
994560b
We see the following errors in the sqlalchemy test suite after mergin…
43c17c1
Instruct mypy to skip tests written by SQLAlchemy maintainers
7f62f1b
Update mypy dependency to fix github actions error
a485bd2
Rename file to match SQLAlchemy guideliens
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update sqlalchemy e2e tests to get valid signal after parameterized q…
…ueries were implemented in DBR Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary because DBSQL can only accept 255 parameters per execution, right now.