refactor(polyfills): do not raise a Assignment call unless needed. #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barelyhuman
requested review from
arikfr,
superdupershant,
yunbodeng-db,
kravets-levko,
andrefurlan-db,
rcypher-databricks,
jackyhu-db and
benc-db
as code owners
|
Fixes #244 |
barelyhuman
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Reaper Gelera <ahoy@barelyhuman.dev>
barelyhuman
had a problem deploying
to
azure-prod
GitHub Actions
Failure
kravets-levko
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand the need for the polyfill, but for various security reasons a few production projects
freezethe ability to modify the constructors so this basically triggers an assignment even when it's not needed and thefreezecause a failure.Let me know if there's other considerations that you'd like to take for this