[PECO-1052] Added enum type class to DBSQLParameter class #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinkdb
requested review from
arikfr,
superdupershant,
yunbodeng-db,
kravets-levko,
susodapop and
andrefurlan-db
as code owners
nithinkdb
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
Can you please update tests (import and use enum values instead of string constants)? Also, please run |
nithinkdb
had a problem deploying
to
azure-prod
GitHub Actions
Failure
| } | ||
|
|
||
| interface DBSQLParameterOptions { | ||
| type?: DBSQLParameterType; | ||
| value: DBSQLParameterValue; | ||
| } | ||
|
|
||
| export default class DBSQLParameter { | ||
| export class DBSQLParameter { |
There was a problem hiding this comment.
Just curious - why you decided to change export type?
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
nithinkdb
force-pushed
the
PECO-1052
branch
from
f4c0478
to
a660960
Compare
nithinkdb
had a problem deploying
to
azure-prod
GitHub Actions
Failure
kravets-levko
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unsafe to allow the user to pick any string. We should instead limit the types that they can set on parameters. We do this via an enum.