-
Notifications
You must be signed in to change notification settings - Fork 21
[PECOBLR-450] Successfull identification of request type in the execute function #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
cbb6a7e
a619c95
74ef808
66748a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package com.databricks.jdbc.common; | ||
|
||
public enum HTTPRequestType { | ||
NOT_SET, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. HTTPRequestType should be UNKNOWN instead of NOT_SET (I guess the weird nomenclature is because you're actually using RequestType as a state for the http client). |
||
THRIFT_OPEN_SESSION, | ||
THRIFT_CLOSE_SESSION, | ||
THRIFT_METADATA, | ||
THRIFT_CLOSE_OPERATION, | ||
THRIFT_CANCEL_OPERATION, | ||
THRIFT_EXECUTE_STATEMENT, | ||
THRIFT_FETCH_RESULTS, | ||
CLOUD_FETCH, | ||
VOLUME_LIST, | ||
VOLUME_SHOW_VOLUMES, | ||
VOLUME_GET, | ||
VOLUME_PUT, | ||
VOLUME_DELETE, | ||
AUTH, | ||
TELEMETRY_PUSH, | ||
OTHER | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's this used for? |
||
}; |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will the retry logic work in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wont work in this case, the request type will be NOT_SET which will be treated as non idempotent.