Show warning message if valueFrom is used instead of value_from in app config section #4429
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Feb 3, 2026
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
changed the title
denik
approved these changes
Feb 4, 2026
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 9fc36ac
23 interesting tests: 7 KNOWN, 5 SKIP, 5 RECOVERED, 4 flaky, 2 FAIL
Top 50 slowest tests (at least 2 minutes):
|
pietern
reviewed
Feb 4, 2026
| if !pv.IsAnchor() { | ||
| // Special case: provide a more helpful message for "valueFrom" vs "value_from" | ||
| if fieldName == "valueFrom" { | ||
| if _, hasValueFrom := info.Fields["value_from"]; hasValueFrom { |
Contributor
There was a problem hiding this comment.
Since we have access to info.Fields, can't we generalize this more for any typo?
E.g. unknown field: %s, did you mean %q?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Show warning message if camel case field is used instead of snake case
Why
DABs syntax uses snake case for all the configuration fields. Sometimes users might use camelCase instead which leads to a warning. With this change we guide users to use the correct field name.
Fixes #4297 (comment)
Tests
Added an acceptance test