Merged
Conversation
fjakobs
force-pushed
the
feat/databricks-client-user-agent
branch
from
64368cc to
81e6a87
Compare
pkosiec
approved these changes
Dec 9, 2025
Member
pkosiec
left a comment
pkosiec
left a comment
There was a problem hiding this comment.
PTAL at my small comment before merge. Thanks!
| return { | ||
| product: "appkit", | ||
| productVersion: version as ClientOptions["productVersion"], | ||
| ...(isDev && { userAgentExtra: { mode: "dev" } }), |
Member
There was a problem hiding this comment.
we could also simply pass the NODE_ENV value directly, right? And attach that property for every request, also including prod for consistency?
Suggested change
| ...(isDev && { userAgentExtra: { mode: "dev" } }), | |
| ...(isDev && { userAgentExtra: { mode: process.env.NODE_ENV } }), |
Collaborator
Author
There was a problem hiding this comment.
This will add too much noise to the logs. Customers can add anything in NODE_ENV
Member
There was a problem hiding this comment.
ok, but then why do we need the dev metadata then? just curious, why not production instead? prod is more important for us, right?
fjakobs
force-pushed
the
feat/databricks-client-user-agent
branch
2 times, most recently
from
b14f568 to
0cbc3e1
Compare
Add AppKit version and dev mode flag to Databricks client user agent. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Fabian Jakobs <fabian.jakobs@databricks.com>
fjakobs
force-pushed
the
feat/databricks-client-user-agent
branch
from
6630b80 to
dbb431e
Compare
MarioCadenas
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
getClientOptions()helper returningClientOptions:product: "appkit"productVersion: "0.0.2"userAgentExtra: { mode: "dev" }(dev mode only)🤖 Generated with Claude Code