refactor(query): remove precision in timestamp type #8154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
b41sh
approved these changes
Oct 12, 2022
drmingdrmer
reviewed
Oct 12, 2022
There was a problem hiding this comment.
Everything is good except there should be a test case that loads the TimestampType message of the version 15, similar to this:
https://github.com/datafuselabs/databend/blob/fb9c11c8c5cf5b7e9c18831dc66532896dd7d1b7/src/meta/proto-conv/tests/it/user_stage.rs#L305
drmingdrmer
approved these changes
Oct 12, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
remove precision in timestamp type
discussion: #8149
Fixes #issue