Skip to content

feat(function-v2): support constructing array and CAST(... AS VARIANT) #7781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2022
Merged

feat(function-v2): support constructing array and CAST(... AS VARIANT) #7781

merged 4 commits into from
Sep 30, 2022

Conversation

andylokandy
Copy link
Contributor

@andylokandy andylokandy commented Sep 21, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • add variadic function array<T0>(T0, T0, T0, ...) :: Array(T0)
  • support CAST( AS VARIANT)

TODO:

  • Build Variant::Array from Array(Variant). Awaiting jsonb encoding support from @b41sh
  • Build Varaint::Object from Tuple.
  • Add unit tests for CAST(... AS VARIANT)

Blocked by #7802
Tracked in #6547

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Sep 21, 2022
@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 9:14AM (UTC)

@andylokandy andylokandy marked this pull request as ready for review September 28, 2022 13:42
@BohuTANG BohuTANG merged commit 1f8dcc3 into databendlabs:main Sep 30, 2022
@andylokandy
Copy link
Contributor Author

This PR introduced a unit test error into main. A PR has been open to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants