Skip to content

refactor(query): extract number types #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 11, 2022
Merged

refactor(query): extract number types #7553

merged 9 commits into from
Sep 11, 2022

Conversation

@andylokandy
Copy link
Contributor

@andylokandy andylokandy commented Sep 9, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Extract number types from DataType, Scalar, ScalarRef, Column, and ColumnBuilder to individual NumberDataType, NumberScalar, NumberColumn, and NumberColumnBuilder
  • Wrap all f32 and f64 into OrderedFloat<f32> and OrderedFloat<f64>

Related to #6547

@andylokandy andylokandy requested a review from sundy-li September 9, 2022 12:11
@vercel
Copy link

vercel bot commented Sep 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 10, 2022 at 8:48PM (UTC)

@andylokandy andylokandy changed the title refactor(query): Extract Number types refactor(query): Extract number types Sep 9, 2022
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 9, 2022
@andylokandy andylokandy requested a review from leiysky September 9, 2022 12:12
@andylokandy andylokandy changed the title refactor(query): Extract number types refactor(query): extract number types Sep 9, 2022
sundy-li
sundy-li reviewed Sep 9, 2022
View reviewed changes
BohuTANG
BohuTANG reviewed Sep 9, 2022
View reviewed changes
@BohuTANG
Copy link
Member

https://github.com/datafuselabs/databend/runs/8282540454?check_suite_focus=true#step:4:1810

test scalars::string::test_string ... FAILED

failures:

---- scalars::string::test_string stdout ----

Goldenfile diff for "string.txt":
To regenerate the goldenfile, run
    REGENERATE_GOLDENFILES=1 cargo test

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

update

✅ Branch has been successfully updated

@BohuTANG
Copy link
Member

test_sqllogic_base_cluster_linux can't passed(I have re-run it many times).

@sundy-li sundy-li merged commit 5d7e38b into databendlabs:main Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@sundy-li sundy-li sundy-li approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees

No one assigned

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andylokandy @BohuTANG @sundy-li