Skip to content

Conversation

@junnplus
Copy link
Contributor

@junnplus junnplus commented Mar 26, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

databendlabs/opensrv#11

[N] ❯ mysql -h 127.0.0.1 -P3306 -u root test
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 8
Server version: 8.0.26-v0.6.91-nightly-93522be-simd(rust-1.61.0-nightly-2022-03-26T12:14:56.337604171+00:00) 0

Copyright (c) 2000, 2022, Oracle and/or its affiliates.

Oracle is a registered trademark of Oracle Corporation and/or its
affiliates. Other names may be trademarks of their respective
owners.

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

mysql> show tables;
+------+
| name |
+------+
| a    |
+------+
1 row in set (0.07 sec)
Read 19 rows, 1.69 KB in 0.051 sec., 372.76 rows/sec., 33.06 KB/sec.
[N] ❯ mysql -h 127.0.0.1 -P3306 -u root system
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 8
Server version: 8.0.26-v0.6.91-nightly-93522be-simd(rust-1.61.0-nightly-2022-03-26T12:14:56.337604171+00:00) 0

Copyright (c) 2000, 2022, Oracle and/or its affiliates.

Oracle is a registered trademark of Oracle Corporation and/or its
affiliates. Other names may be trademarks of their respective
owners.

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

mysql> show tables;
+--------------+
| name         |
+--------------+
| clusters     |
| columns      |
| configs      |
| contributors |
| credits      |
| databases    |
| engines      |
| functions    |
| metrics      |
| one          |
| processes    |
| query_log    |
| roles        |
| settings     |
| tables       |
| tracing      |
| users        |
| warehouses   |
+--------------+
18 rows in set (0.07 sec)
Read 19 rows, 1.69 KB in 0.047 sec., 404.9 rows/sec., 35.91 KB/sec.

Changelog

  • Bug Fix

Related Issues

Fixes #4430

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Mar 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/8mWAQuBLBvsCN3juVhzhk2jkZeLm
✅ Preview: Canceled

[Deployment for f92aaec canceled]

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Mar 26, 2022
@junnplus junnplus marked this pull request as ready for review March 26, 2022 12:21
@junnplus junnplus requested a review from BohuTANG as a code owner March 26, 2022 12:21
@junnplus junnplus requested a review from Xuanwo March 26, 2022 12:21
@BohuTANG
Copy link
Member

Seems the management mode tests affected by this patch.
Management mode 'sudo use tenant' is not used anymore, it's time to remove the logic and tests related.
There's a issue about it:
#4474

@junnplus
Copy link
Contributor Author

Seems the management mode tests affected by this patch.

Emm.., The current tenant in management mode is empty by default.

Management mode 'sudo use tenant' is not used anymore, it's time to remove the logic and tests related.

Yep, I'll follow up on this.

I fix this first, read the configured tenant if the current tenant is not set.

Signed-off-by: Ye Sijun <junnplus@gmail.com>
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@BohuTANG BohuTANG merged commit de61146 into databendlabs:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Query doesn't support mysql reconnect correctly

3 participants