Skip to content

Conversation

@drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Jul 19, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore: remove local state-machine-api directory
  • Directory has been successfully migrated to external crate
  • All references now use external git dependency
  • Compilation verified to work with external crate only
refactor: migrate state-machine-api to external crate
  • Move src/meta/state-machine-api to standalone external crate
  • Update all Cargo.toml files to reference external git repository
  • Replace crate name from databend_common_meta_state_machine_api to state_machine_api
  • Use tagged version v0.1.0 from https://github.com/databendlabs/state-machine-api.git
  • Update 28+ Rust files with new import paths
  • All compilation and lint checks passing

External crate details:

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

- Move src/meta/state-machine-api to standalone external crate
- Update all Cargo.toml files to reference external git repository
- Replace crate name from databend_common_meta_state_machine_api to state_machine_api
- Use tagged version v0.1.0 from https://github.com/databendlabs/state-machine-api.git
- Update 28+ Rust files with new import paths
- All compilation and lint checks passing

External crate details:
- Repository: https://github.com/databendlabs/state-machine-api.git
- Tag: v0.1.0
- CI: Passing with GitHub Actions
- Tests: 22 tests passing
- Directory has been successfully migrated to external crate
- All references now use external git dependency
- Compilation verified to work with external crate only
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jul 19, 2025
@drmingdrmer drmingdrmer marked this pull request as ready for review July 20, 2025 01:39
@drmingdrmer drmingdrmer merged commit aae2c53 into databendlabs:main Jul 20, 2025
167 of 170 checks passed
@drmingdrmer drmingdrmer deleted the 357-external-state-machine-api branch July 20, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant