-
Notifications
You must be signed in to change notification settings - Fork 771
refactor: Improved Hilbert Clustering with Range Partition #17424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aad29f2
to
f2530ea
Compare
f2530ea
to
db12a2b
Compare
Docker Image for PR
|
dantengsky
reviewed
Mar 19, 2025
@zhyass Pushed a commit with some extra code comments, hoping they’re helpful. Please help check if there are any incorrect descriptions and revise them. |
9fae32b
to
3084292
Compare
dantengsky
approved these changes
Mar 20, 2025
loloxwg
pushed a commit
to loloxwg/databend
that referenced
this pull request
Apr 3, 2025
…abs#17424) * fix * fix * fix * fix * fix * fix * update * for test * for test * for test * for test * fix * fix * fix * remove m_cte * fix * fix * fix * fix * fix * restore m cte * fix * fix * fix * remove m_cte * fix * fix * fix * fix * fix * fix * fix * fix * for test * fix * fix * fix * fix * for test * fix * fix memory size * fix * fix * fix * fix * fix * fix * fix * recover * fix * fix * fix * fix * fix fix fix * fix * fix test * fix test * fix test * fix test * add hilbert_range_index * fix * fix * fix * fix * fix * fix * fix * chore: add some extra code comments --------- Co-authored-by: dantengsky <dantengsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-cloud
Build docker image for cloud test
pr-refactor
this PR changes the code base without new features or bugfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR introduces an improved implementation of Hilbert clustering, replacing the original global sorting approach with a more efficient range partition strategy. The new approach significantly reduces computational overhead and improves performance, especially for large-scale datasets.
Tests
Type of change
This change is