Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): using Bitmap::new_constant to replace constant_bitmap and extend_constant #13309

Merged
merged 4 commits into from
Oct 18, 2023
Merged

chore(query): using Bitmap::new_constant to replace constant_bitmap and extend_constant #13309

merged 4 commits into from
Oct 18, 2023

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Oct 18, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

After adding Bitmap::new_constant in jorgecarleitao/arrow2#1579, we can use it to replace constant_bitmap and extend_constant, which can avoid doing a bitcount when converting MutableBitmap to Bitmap.

  • Closes #issue

This change is Reviewable

@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 7:44am

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 18, 2023
@Dousir9 Dousir9 added the ci-benchmark Benchmark: run all test label Oct 18, 2023
@Dousir9 Dousir9 changed the title chore(query): use Bitmap::new_constant chore(query): using Bitmap::new_constant to replace constant_bitmap and extend_constant Oct 18, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13309-0f6ac6f

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Dousir9 Dousir9 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Oct 18, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13309-edd334d

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report

@sundy-li sundy-li added this pull request to the merge queue Oct 18, 2023
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 18, 2023
@BohuTANG BohuTANG merged commit 6262730 into databendlabs:main Oct 18, 2023
69 checks passed
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@Dousir9 @andylokandy
chore(query): using Bitmap::new_constant to replace constant_bitmap a…
055fe2e 
…nd extend_constant (databendlabs#13309)

* use new_constant

* update dependence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@xudong963 xudong963 Awaiting requested review from xudong963

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dousir9 @sundy-li @BohuTANG