Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改进文字导出 #167

Merged
merged 1 commit into from
Jan 26, 2021
Merged

改进文字导出 #167

merged 1 commit into from
Jan 26, 2021

Conversation

casouri
Copy link
Contributor

@casouri casouri commented Jan 25, 2021

目前导出的文字里换行都被吞了,看起来不清楚;另外微博里的链接直接导出成“微博链接”四个字,没有url。这个PR能正常导出换行,链接会换成明文url。

改coding注释是因为Emacs说格式不正确(

@dataabc
Copy link
Owner

dataabc commented Jan 25, 2021

感谢贡献代码。第一个commit是不错的,第二个commit也不错,有两个小问题:
1.因为会修改selector,导致后面话题和艾特会无法获取;
2.因为删除链接中的文字,会显得不完整,可以对比下修改前后,修改后多了链接,少了文字,个人觉得前者更好一点,这仅是我个人的看法,如果有不同看法,我们可以讨论。

综上,如果只有第一个commit是可merge的,第二个commit还有待修改,或者丢弃第二个commit,或者咱们讨论修改。再次感谢贡献代码。

@casouri
Copy link
Contributor Author

casouri commented Jan 25, 2021

我没有意见,照你说的改就可以。你可以直接改PR吗?还是要怎么改?我不太会用GitHub www

@dataabc
Copy link
Owner

dataabc commented Jan 25, 2021

直接把第二个的修改还原,或者重新fork后按第一个的修改。

@casouri
Copy link
Contributor Author

casouri commented Jan 25, 2021

第二个commit不改了吗?

@dataabc
Copy link
Owner

dataabc commented Jan 25, 2021

在现在的基础上加上第一个的改动就行,我比较了第二个的结果,觉得还是不加第二个好点。

你可以把第二个的修改再改回去做成第三个commit,或者重新fork,按照第一个的commit改。

@casouri
Copy link
Contributor Author

casouri commented Jan 25, 2021

整好了。这样就可以了吗?

@dataabc dataabc merged commit 38b1a61 into dataabc:master Jan 26, 2021
@dataabc
Copy link
Owner

dataabc commented Jan 26, 2021

已merge。

感谢贡献代码,如果还有其它建议也可以继续讨论,再次感谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants