Skip to content

Conversation

samvmdev
Copy link
Contributor

@samvmdev samvmdev commented Sep 1, 2022

This PR will work for individual blog posts. There will need to be some edits made to the preview page (article.html) in order to have the correct reading time to show up, perhaps due to how it is calculated. Currently, reading time shows up with the same time for all previews.

What kind of change does this PR introduce?

This PR adds the reading time indicator to the main post page (e.g. "5 minutes to read")

Does this PR introduce a breaking change?

Unsure

What needs to be documented once your changes are merged?

Perhaps a changelog or some kind of tracker indicating that reading time has been implemented. Otherwise, none.

Snapshot from local host

post-layout-reading-time

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for amazing-borg-b90f51 ready!

Name Link
🔨 Latest commit 54a5f71
🔍 Latest deploy log https://app.netlify.com/sites/amazing-borg-b90f51/deploys/63135bc818907a0008360d69
😎 Deploy Preview https://deploy-preview-51--amazing-borg-b90f51.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reshamas
Copy link
Member

reshamas commented Sep 2, 2022

@greenhacks Thanks for this PR. Are we able to reduce the size of the font so it matches the size of "Data Umbrella" author?

@samvmdev
Copy link
Contributor Author

samvmdev commented Sep 3, 2022

Hi Reshama, yes. Here is a preview. I just updated the branch.

Screen Shot 2022-09-03 at 6 48 26 AM

@reshamas
Copy link
Member

reshamas commented Sep 3, 2022

Hi @greenhacks
(cc: iliadeleon , not sure what the Figma design is.)

REF: https://blog.codeforscience.org/announcing-the-newest-event-fund-grantees/

Can we have it in this format, attached view as an example:
Screen Shot 2022-09-03 at 11 37 32 AM

@samvmdev
Copy link
Contributor Author

samvmdev commented Sep 6, 2022

Hi @reshamas, I was working off the original Figma design for this PR; I'd be glad to try working on the new design.

Figma link: https://www.figma.com/file/rs7dsdmKlxdfuQ0wobp5B2/Data-Umbrella
Figma Screenshot:
Screen Shot 2022-09-06 at 7 29 30 AM

@reshamas
Copy link
Member

reshamas commented Sep 6, 2022

Hi @greenhacks
I think there are two places where we want to add the reading time.

  1. The home page which has thumbnails to the blogs.
  2. Each individual blog page.

I think, for both, we can do as follows:

Author
dd mmm yy * x min read

Screen Shot 2022-09-06 at 10 48 36 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants