Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor input validation code #7

Closed
2 tasks done
marta- opened this issue Oct 14, 2020 · 1 comment
Closed
2 tasks done

Refactor input validation code #7

marta- opened this issue Oct 14, 2020 · 1 comment
Assignees

Comments

@marta-
Copy link
Contributor

marta- commented Oct 14, 2020

  • Separate functions for validating each component
  • For health card validation: implement a map from province code to validation function plus a default validation function for .
veronikaslc pushed a commit that referenced this issue Oct 15, 2020
Refactored code
Display errors and guids for all line in order
marta- added a commit that referenced this issue Oct 16, 2020
Reorganized code for health card validation, hopefully making it somewhat easier to plug in additional validators for other provinces and teritories.
marta- added a commit that referenced this issue Oct 19, 2020
Small improvements to error message presentation
@marta-
Copy link
Contributor Author

marta- commented Oct 19, 2020

Further improvements and fixes to current code:

  • If all input lines are invalid, the button should remain disabled Won't do for now, as it may create confusion re why the button remains disabled
  • When pasting content directly from a spreadsheet where the separator is \t, all lines are marked as invalid because of this separator
  • For any line that contains a <health card, province> pair that was already encountered on a previous line, but with a different date of birth, invalidate and show the error:"ON health card number 1234567890 has already been entered on line 12 with a different date of birth" (where 12 is the line where the pair 1234567890,ON first appeared).

veronikaslc pushed a commit that referenced this issue Oct 19, 2020
Small color labeling change and rewording main input label
veronikaslc pushed a commit that referenced this issue Oct 19, 2020
When pasting content directly from a spreadsheet where the separator is \t, all lines are marked as invalid because of this separator
veronikaslc pushed a commit that referenced this issue Oct 19, 2020
Check <health card, province> pair that was already encountered on a previous line
marta- added a commit that referenced this issue Oct 19, 2020
Fixed bug with undefined provincial health card validator
marta- added a commit that referenced this issue Oct 19, 2020
Duplicate reporting: fixed reported index of duplicate HC, improved code readability
veronikaslc pushed a commit that referenced this issue Oct 20, 2020
Use indexes as keys for generated guid data
veronikaslc pushed a commit that referenced this issue Oct 20, 2020
@marta- marta- closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants