Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error for making identical deals #427

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Dec 9, 2023

In the case where provider failed to return success response, Singularity will retry the same deal which may end up with being rejected as boost has already received the same deal proposal.

This makes Singularity continue to next deal instead of keep retrying on the same "identical deal" error message.

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0820a8e) 74.09% compared to head (51d0824) 74.14%.
Report is 1 commits behind head on main.

Files Patch % Lines
service/dealpusher/dealpusher.go 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   74.09%   74.14%   +0.05%     
==========================================
  Files         150      150              
  Lines        9940     9944       +4     
==========================================
+ Hits         7365     7373       +8     
+ Misses       1819     1816       -3     
+ Partials      756      755       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit 0bcd973 into main Dec 30, 2023
12 checks passed
@xinaxu xinaxu deleted the xinaxu/ignore-identical-deal branch December 30, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants