Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetFileDeals should return deals for each file range #423

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Nov 17, 2023

First step to address filecoin-project/motion#228
This changes GetFileDealsHandler to return list of deals for each FileRange.

@xinaxu xinaxu requested a review from gammazero November 17, 2023 17:54
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (978935b) 74.20% compared to head (1093cb7) 74.23%.

❗ Current head 1093cb7 differs from pull request most recent head bd92f63. Consider uploading reports for the commit bd92f63 to get more accurate results

Files Patch % Lines
handler/file/deals.go 72.72% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   74.20%   74.23%   +0.02%     
==========================================
  Files         150      150              
  Lines        9926     9936      +10     
==========================================
+ Hits         7366     7376      +10     
  Misses       1806     1806              
  Partials      754      754              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but check test errors:

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x18 pc=0x7ff73e0aa5c3]

goroutine 41639 [running]:
github.com/data-preservation-programs/singularity/storagesystem.(*readerWithRetry).Close(0x7ff73c5c8675?)
	D:/a/singularity/singularity/storagesystem/rclone.go:166 +0x43
github.com/data-preservation-programs/singularity/store.(*PieceReader).Close(0x0?)
	D:/a/singularity/singularity/store/piece_store.go:328 +0x5a
github.com/data-preservation-programs/singularity/handler.download.func1(0x7)
	D:/a/singularity/singularity/handler/download.go:131 +0x8a9
created by github.com/data-preservation-programs/singularity/handler.download
	D:/a/singularity/singularity/handler/download.go:88 +0x377
FAIL	github.com/data-preservation-programs/singularity/cmd	125.491s

@xinaxu xinaxu merged commit 41836a3 into main Nov 17, 2023
11 checks passed
@xinaxu xinaxu deleted the xinaxu/get-file-deals branch November 17, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants