Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log for retrieval paths #420

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: add log for retrieval paths #420

merged 1 commit into from
Nov 9, 2023

Conversation

rvagg
Copy link
Contributor

@rvagg rvagg commented Nov 8, 2023

No indication on standard log output of any of this happening, which is odd given a lot of the other stuff that comes out.

@rvagg rvagg changed the title feat: add log for Retrieve() call feat: add log for retrieval paths Nov 8, 2023
@rvagg rvagg force-pushed the rvagg/retrieve-log branch 3 times, most recently from cb11aef to 0d78ff5 Compare November 8, 2023 06:03
@rvagg rvagg force-pushed the rvagg/retrieve-log branch from 0d78ff5 to 4866ae1 Compare November 8, 2023 06:03
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d540e3) 74.02% compared to head (4866ae1) 73.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   74.02%   73.97%   -0.05%     
==========================================
  Files         149      149              
  Lines        9823     9826       +3     
==========================================
- Hits         7271     7269       -2     
- Misses       1802     1805       +3     
- Partials      750      752       +2     
Files Coverage Δ
handler/file/retrieve.go 64.76% <100.00%> (+0.36%) ⬆️
retriever/retriever.go 56.33% <100.00%> (+0.62%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit ed0cc7b into main Nov 9, 2023
@gammazero gammazero deleted the rvagg/retrieve-log branch November 9, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants