Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for rangeReader #410

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add unit test for rangeReader #410

merged 2 commits into from
Nov 2, 2023

Conversation

gammazero
Copy link
Collaborator

  • Add unit test
  • Simplify retrieve logic

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c4db87) 73.90% compared to head (77a2e21) 73.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   73.90%   73.97%   +0.07%     
==========================================
  Files         149      149              
  Lines        9829     9819      -10     
==========================================
  Hits         7264     7264              
+ Misses       1813     1804       -9     
+ Partials      752      751       -1     
Files Coverage Δ
handler/file/retrieve.go 64.39% <100.00%> (+1.71%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 1806176 into main Nov 2, 2023
@gammazero gammazero deleted the add-unit-test branch November 2, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant