Cherry-pick: Jetty HTTP Upgrade #340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krish-cloudsufi
changed the title
Krish-cloudsufi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Jetty (org.eclipse.jetty:jetty-http:9.4.12.v20180830) – Jetty accepts the '+' character preceding the Content-Length value in an HTTP/1 header field. This behavior is more permissive than allowed by the RFC and can potentially lead to HTTP request smuggling when Jetty is used in combination with servers that reject such requests (e.g., NGINX, Apache).
Even though no active exploit has been reported, the issue could enable attackers to bypass security controls such as WAF or IDS when different components interpret the same request differently.
Root Cause:
Jetty’s HTTP parser accepts a '+' sign before numeric values in the Content-Length header (e.g., Content-Length: +16), which violates RFC 9110 Section 8.6
.
This inconsistency in request parsing can cause mismatched interpretations between Jetty and other proxy or upstream servers, potentially leading to request smuggling or partial request injection scenarios.
CVEs:
Fix:
Upgraded the Jetty HTTP dependency from version 9.4.12.v20180830 to 9.4.52.v20230823, where this issue is fixed.
Upgrade Salesforce version from 1.7.1 to 1.7.2-SNAPSHOT
CVE Fix Verification: https://screenshot.googleplex.com/7LZHErfRWhVPdWF
JIRA : [PLUGIN-1934]