Skip to content

Update failsafe plugin goal to fix build issue #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

poojantcs
Copy link
Contributor

@poojantcs poojantcs commented Jul 13, 2023

Issue: Build is successful even though there are errors in integration-tests. Ref build: https://github.com/data-integrations/database-plugins/actions/runs/5353400448/jobs/9709247509

Before:

Screenshot 2023-07-13 at 11 20 49

After the fix:
Screenshot 2023-07-13 at 11 22 01

Screenshot 2023-07-13 at 11 21 31

@google-cla
Copy link

google-cla bot commented Jul 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MrRahulSharma MrRahulSharma self-requested a review July 19, 2023 04:53
Copy link
Contributor

@MrRahulSharma MrRahulSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vipinofficial11
Copy link
Contributor

Merging the PR as the Build is completely green.

@Vipinofficial11 Vipinofficial11 merged commit a34798a into data-integrations:develop Jul 25, 2023
@psainics psainics deleted the fixIntegrationTestBuildIssue branch January 22, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants