-
Notifications
You must be signed in to change notification settings - Fork 1
Deploy to GCP #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to GCP #26
Conversation
GitHub Action deploy (so that I can trigger the branch.)
GitHub Action deploy
I'm suspecting the ssh-compute is not working. because if I paste the command and cloud console it needs us to wrap the command between "" to be able to run.
GitHub Action deploy
Also update settings in gcp
GitHub Action deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an automated deployment workflow to Google Cloud Platform using Workload Identity Federation (WIF), replacing the legacy Render deployment workflow.
- Added a new GCP deployment workflow (.github/workflows/deploy_gcp.yml) that authenticates with GCP and remotely executes a deployment script.
- Removed the old Render deployment workflow (.github/workflows/deploy.yml).
- Added a deployment script (.github/scripts/deploy_deepgit.sh) for building and deploying both frontend and backend components.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/deploy_gcp.yml | New workflow enabling deployment to GCP via SSH and Workload Identity. |
.github/workflows/deploy.yml | Legacy Render deployment workflow removed. |
.github/scripts/deploy_deepgit.sh | New deployment script to pull the deploy branch, build, and deploy code. |
git pull origin deploy | ||
|
||
# build and deploy the frontend | ||
cd ~/projects/deepgit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory change 'cd ~/projects/deepgit' is repeated (line 5 and line 9). Consider removing the redundant command to streamline the script.
cd ~/projects/deepgit |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it to make it more clear.
Uh oh!
There was an error while loading. Please reload this page.