Skip to content

Unskip PF4 wizard test #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Aug 10, 2020

closes #649

Seems that #666 fixed this issue too. I cannot reproduce it.

@rvsia rvsia added PF4 PF4 pull request Technical debt labels Aug 10, 2020
@rvsia rvsia requested a review from Hyperkid123 August 10, 2020 10:43
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         212      212           
  Lines        3312     3312           
  Branches     1076     1076           
=======================================
  Hits         3070     3070           
  Misses        242      242           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14bb78...cde3864. Read the comment docs.

Copy link
Member

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Hyperkid123 Hyperkid123 merged commit 3fec179 into data-driven-forms:master Aug 10, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.8.9 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the unskipPF4WizardTest branch August 20, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unreliable async test in PF4 wizard
2 participants