Skip to content

fix(common): Fix clear all right values dual list action type typo #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

Hyperkid123
Copy link
Member

Fixes hanging remove button is enabled even if no option is selected

Description

Fixed dual list select action dispatch typo

https://codesandbox.io/s/modal-multiselect-forked-7w9yl7?file=/src/index.js

How to produce:

  1. select one option and add it to the right
  2. click on the option in the right column but make no other action
  3. Click on the Remove all button

The remove button stays enabled (as if the option was still selected)

The button should be disabled

@Hyperkid123 Hyperkid123 added the bug Something isn't working label Jun 16, 2022
@Hyperkid123 Hyperkid123 requested a review from rvsia June 16, 2022 13:59
@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.18.2 [DataDrivenFormsBot]

@rvsia rvsia added the common label Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1274 (2a4821a) into master (2b9bcf0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         209      209           
  Lines        3623     3623           
  Branches     1264     1264           
=======================================
  Hits         3443     3443           
  Misses        180      180           
Impacted Files Coverage Δ
...es/common/src/dual-list-select/dual-list-select.js 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rvsia rvsia merged commit 1c3f932 into master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working common released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants