Skip to content

fix(pf4): use options from field hook #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Nov 5, 2021

Options were taken from props, not from enhanced props, so resolveProps didn't work here.

@rvsia rvsia added bug Something isn't working PF4 PF4 pull request labels Nov 5, 2021
@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.15.7 [DataDrivenFormsBot]

@rvsia rvsia requested a review from karelhala November 5, 2021 10:52
Copy link
Collaborator

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1170 (13966fa) into master (189a268) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         209      209           
  Lines        3571     3571           
  Branches     1237     1237           
=======================================
  Hits         3389     3389           
  Misses        182      182           
Impacted Files Coverage Δ
packages/pf4-component-mapper/src/radio/radio.js 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189a268...13966fa. Read the comment docs.

@rvsia rvsia merged commit 7ce49d5 into data-driven-forms:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants